[Fix] coredump if add new c++ metrics#666
Merged
ygwpz merged 1 commit intoModelEngine-Group:developfrom Jan 23, 2026
Merged
Conversation
flesher0813
requested review from
FangRun2,
Tarrei,
mag1c-h and
ygwpz
as code owners
ygwpz
approved these changes
Jan 22, 2026
flesher0813
force-pushed
the
develop_obserbility
branch
from
dedfdca to
7cba6b5
Compare
ygwpz
approved these changes
Jan 22, 2026
flesher0813
force-pushed
the
develop_obserbility
branch
from
7cba6b5 to
05a622a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
What this PR does / why we need it?
When adding new metric in c++, it would core dump and print "Please call SetUp() first!"
Modifications
Does this PR introduce any user-facing change?
No using changes
Test
How was this patch tested?
Tested with adding new metrics and online services
